This is OK to commit. The option description is currently: "Dump the coverage mapping records that will be emitted in a translation unit”
How about changing that to the following? "Dump the coverage mapping records, for testing” There are some other “dump” options with similar descriptions, and I think it’s useful to suggest the purpose of the option. > On Aug 5, 2014, at 4:28 PM, Alex Lorenz <[email protected]> wrote: > > Hi bob.wilson, bogner, > > This patch adds a new option called 'dump-coverage-mapping'. It allows us to > test coverage mapping generation without relying on llvm-cov. > > http://reviews.llvm.org/D4799 > > Files: > include/clang/Driver/CC1Options.td > include/clang/Frontend/CodeGenOptions.def > lib/CodeGen/CodeGenModule.cpp > lib/CodeGen/CodeGenPGO.cpp > lib/CodeGen/CoverageMappingGen.cpp > lib/CodeGen/CoverageMappingGen.h > lib/Frontend/CompilerInvocation.cpp > <D4799.12214.patch> _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
