On Sun, Aug 10, 2014 at 04:19:43PM -0700, Chandler Carruth wrote: > On Sat, Aug 9, 2014 at 11:28 AM, Joerg Sonnenberger <[email protected]> wrote: > > > NetBSD/aarch64 has no libgcc or libstdc++. Drop arm64 tests. > > > > OK... > > > > > > Modified: > > cfe/trunk/lib/Driver/ToolChains.cpp > > cfe/trunk/lib/Driver/Tools.cpp > > cfe/trunk/test/Driver/netbsd.c > > cfe/trunk/test/Driver/netbsd.cpp > > > > Modified: cfe/trunk/lib/Driver/ToolChains.cpp > > URL: > > http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains.cpp?rev=215291&r1=215290&r2=215291&view=diff > > > > ============================================================================== > > --- cfe/trunk/lib/Driver/ToolChains.cpp (original) > > +++ cfe/trunk/lib/Driver/ToolChains.cpp Sat Aug 9 13:28:36 2014 > > @@ -2643,6 +2643,7 @@ NetBSD::GetCXXStdlibType(const ArgList & > > getTriple().getOSVersion(Major, Minor, Micro); > > if (Major >= 7 || (Major == 6 && Minor == 99 && Micro >= 49) || Major > > == 0) { > > switch (getArch()) { > > + case llvm::Triple::aarch64: > > > > But you also added cases to these switches? If this is actually just to > drop the tests below, it'd be nice to explain why in the commit log. As-is, > these look like unintentional commits or untested changes?
There are two parts: (1) Drop arm64, aarch64 is still tested. I could have done this one separately. (2) For aarch64, expect CRT in libc, not libgcc. Use libc++. Joerg _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
