On Tue, Aug 12, 2014 at 8:57 AM, Rafael EspĂ­ndola
<[email protected]> wrote:
> On 11 August 2014 18:08, David Blaikie <[email protected]> wrote:
>> Author: dblaikie
>> Date: Mon Aug 11 17:08:06 2014
>> New Revision: 215391
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=215391&view=rev
>> Log:
>> Change MemoryBuffer* to MemoryBuffer& parameter to Lexer::ComputePreamble
>>
>
> Since the name of the buffer is not used, a StringRef seems an even
> better match.

Good point!

> I changed it in r215448 since I coded the patch to test it out.

Thanks!

>
> Cheers,
> Rafael

_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to