================
Comment at: 
test/localization/locale.categories/category.time/locale.time.get.byname/get_one.pass.cpp:117
@@ -104,2 +116,2 @@
                           "\xD0\xBE\xD1\x82\xD0\xB0"
                           ", 31 "
----------------
Eric Fiselier wrote:
> Dan Albert wrote:
> > Phabricator: "Context not available"
> > Me: Damn you, Phabricator!
> > 
> > *checks the source*
> > 
> > Well, that didn't make it any clearer. I presume that mess of hex is 
> > encoding cyrillic characters. Are these tests like the other Russian ones 
> > where the separators are wrong? If so, XFAIL, not #ifdef.
> Done. Changed backed out. I suspect the difference is between upper and lower 
> case cyrillic characters. However more investigation is needed.
@danalbert: the "Context not available" bit isn't phabricator's fault. This 
happens when a patch is made without '-U999'.

================
Comment at: 
test/localization/locale.categories/category.time/locale.time.put.byname/put1.pass.cpp:73
@@ -72,1 +72,3 @@
+        // w/ GLIBC fr_FR.UTF-8 day abreviations can end with a '.'
         assert((ex == "Today is Samedi which is abbreviated Sam.")||
+               (ex == "Today is samedi which is abbreviated sam." )||
----------------
Eric Fiselier wrote:
> Dan Albert wrote:
> > What's with the case differences? I see that was actually already the case, 
> > but why?
> Not sure. glibc uses lower case. I've seperated the glibc change and only 
> check the lower case version.
The lowercase versions of that abbreviation are suspect to me. IIRC French 
folks capitalize it always.

http://reviews.llvm.org/D4861



_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to