================
Comment at: lib/CodeGen/ItaniumCXXABI.cpp:1450
@@ -1449,3 +1449,3 @@
llvm::Value *ItaniumCXXABI::InitializeArrayCookie(CodeGenFunction &CGF,
llvm::Value *NewPtr,
----------------
Hm, I think we'd need to ask Timur to implement similar logic for Microsoft ABI?
================
Comment at: lib/CodeGen/ItaniumCXXABI.cpp:1482
@@ +1481,3 @@
+ CGM.getSanitizerMetadata()->disableSanitizerForInstruction(SI);
+ llvm::FunctionType *fty =
+ llvm::FunctionType::get(CGM.VoidTy, NumElementsTy, false);
----------------
Please start local variable names with capitals
================
Comment at: lib/CodeGen/ItaniumCXXABI.cpp:1483
@@ +1482,3 @@
+ llvm::FunctionType *fty =
+ llvm::FunctionType::get(CGM.VoidTy, NumElementsTy, false);
+ llvm::Constant *f =
----------------
Why don't you use fixed type for __asan_poison_cxx_array_cookie (like IntptrTy)?
http://reviews.llvm.org/D4774
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
