r216447! ================ Comment at: compiler-rt/trunk/lib/asan/asan_uar_thunk.cc:1 @@ +1,2 @@ +//===-- asan_uar_thunk.cc -------------------------------------------------===// +// ---------------- samsonov wrote: > Consider clarifying that this is Windows-specific file in the filename. Good idea! I've made it `asan_win_uar_thunk.cc`, I'll also rename `asan_dll_thunk.cc` to `asan_win_dll_thunk.cc` in a separate change for consistency.
Please note that I've intentionally left the `.lib` filename unchanged as it doesn't make sense to put `win` in there. ================ Comment at: compiler-rt/trunk/lib/asan/asan_uar_thunk.cc:30 @@ +29,2 @@ +} +#endif // ASAN_DLL_THUNK ---------------- samsonov wrote: > wrong comment Good catch -- thanks! http://reviews.llvm.org/D5051 _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
