Code looks good. I would suggest adding to the comment above the AnalyzerOptions setting to explain why we still want to do any processing at all (i.e. to validate the command-line options and ensure the file still parses, as you pointed out to me yesterday).
Nitpick: the option should be next to other bitfield options; otherwise it will take up a whole word on its own. Jordan > On Aug 29, 2014, at 11:38, Anna Zaks <[email protected]> wrote: > > Please, review: > > Add an option to silence all analyzer warnings. > > People have been incorrectly using "-analyzer-disable-checker" to > silence analyzer warnings on a file, when analyzing a project. Add > the "-analyzer-disable-all-checks" option, which would allow to do > this and suggest it as part of the error message for > "-analyzer-disable-checker". > > <disable-all-checks.diff>
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
