On 29 August 2014 14:34, Dmitri Gribenko <[email protected]> wrote: > These intrinsics should have tests. Yes, there are IR-checking tests > for some of them, but I think they are underconstrained in most cases. > What about actual execution tests in compiler-rt?
This is a good point, but I don't think compiler-rt is the right place for it, as not many buildbots test them, and that's not *really* a compiler-rt issue. The test-suite is probably the best place for that, but we'd have to create a lot of platform specific tests and make sure all of them have the exact same output, as our lnt infrastructure is not able to cope with platform-specific output. Another way is to get the hardware manufacturers themselves (like ARM) to run exhaustion tests before commit. But with the ACLE being a new thing, I'm not sure they got that far yet. I'll keep that in mind and request some proof of extensive coverage before approval, if adding tests is not possible due to our own infrastructure problems. cheers, --renato _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
