-Wc++98-compat doesn't make sense here: that warning group is for warning on code that is valid in the current language but not in C++98.
The right way to make this change would be to downgrade this from ExtWarn to Extension. On 6 Sep 2014 16:08, "Nico Weber" <[email protected]> wrote: > Hi, > > the attached (tiny) patch changes the ""C++98 requires an accessible copy > constructor" warning to be DefaultIgnore, like e.g. "commas at the end of > enumerator lists are incompatible with C++98" is. The reasoning is that > this construct is accepted by all compilers and valid in C++11, so it > doesn't seem like a useful warning to have enabled by default. Building > with -pedantic, -Wbind-to-temporary-copy, or -Wc++98-compat still shows the > warning. > > The motivation is that I built re2, and this was the only warning that was > emitted during the build. Both changing re2 to fix the warning and > detecting clang and suppressing the warning in re2's build seem inferior > than just giving the compiler a good default for this warning. > > Ok? > > Nico > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
