Hi Tim, Response in-line: On 08/09/2014 10:37, "Tim Northover" <[email protected]> wrote:
>Hi Assad, > >On 5 September 2014 12:41, Assad Hashmi <[email protected]> wrote: >> Note that these are related to Graham Hunter¹s patch, (AArch32 v8 NEON >> intrinsics for numeric max/min and directed rounding to integral), and >>were >> unit tested together. > >I think this looks OK. The diff incorporates part of Graham's patch, >though, doesn't it? I'd expect to see just the guards changing in >arm_neon.td otherwise. Yes. I thought it best to unit test and submit the patch as a co-dependency. > >Could you make sure it goes in after his changes, rather than before, >for clarity of revision history? AIUI Graham¹s patch was committed to the trunk on Friday, rev 217242: http://llvm.org/viewvc/llvm-project?view=revision&revision=217242 Does that mean mine can go in at any time now that 217242 is in? > >Cheers. > >Tim. _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
