> On Thu, Sep 11, 2014 at 10:08:18AM -0700, Hans Wennborg wrote: >> On Wed, Sep 10, 2014 at 2:46 PM, Joerg Sonnenberger >> <[email protected]> wrote: >> > On Wed, Sep 10, 2014 at 09:25:37PM -0000, Joerg Sonnenberger wrote: >> >> Author: joerg >> >> Date: Wed Sep 10 16:25:37 2014 >> >> New Revision: 217546 >> >> >> >> URL: http://llvm.org/viewvc/llvm-project?rev=217546&view=rev >> >> Log: >> >> Only override the target architecture on -m32 and friends if it is >> >> actually different. Fixes a surprising link error with nodejs on rpi, >> >> where armv6-netbsd-eabihf turned into armv5e-netbsd-eabihf, which >> >> doesn't lacks the necessary VFP support. >> > >> > This should be merged into the 3.5 branch, but I am not sure who is >> > responsible for maintaining it? >> >> Tom said he would do 3.5.1. > > This looks OK to me, can you get approval from the code owner?
LGTM. However, I'd prefer the lit test use a single FileCheck, rather than many grep commands. That change only needs to make it to mainline. Chad _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
