Thanks. However, tests like these should go in unittests/Format/FormatTest.cpp. Sorry for not being more precise before.
On Tue, Sep 16, 2014 at 5:41 PM, Eugene Toder <[email protected]> wrote: > Thank you. Now with a test. > > Eugene > > > On Mon, Sep 15, 2014 at 6:10 PM, Daniel Jasper <[email protected]> wrote: > >> I think the change itself look good (although I don't use inline assembly >> much). Please add a test. >> >> On Mon, Sep 15, 2014 at 11:14 PM, Eugene Toder <[email protected]> wrote: >> >>> Hello, >>> >>> When inline assembly has only clobber constraints it's common to write >>> all three colons without spaces, for example: >>> >>> asm volatile("nop" ::: "memory"); >>> >>> Currently clang-format splits ::: into coloncolon and colon, and inserts >>> a space before the colon, which looks strange: >>> >>> asm volatile("nop" :: : "memory"); >>> >>> I suggest to allow having ::: without spaces in this case. Attached is a >>> simple patch to that effect. >>> >>> Thanks, >>> Eugene >>> >>> _______________________________________________ >>> cfe-commits mailing list >>> [email protected] >>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits >>> >>> >> >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
