================
Comment at: llvm/tools/clang/test/CodeGen/Debug-info-explicitcast.c:13
@@ +12,3 @@
+};
+void foo3(struct S3 *p) { p->i++; }
+
----------------
This case isn't so interesting, and isn't related to explicit casts - this case
the type S3 will be emitted because we emit the function definition for foo3
and need to describe the type of its parameter (initially it would be built as
just a declaration, but then when we see the ->, the type will be required to
be complete and we'll upgrade it to a definition)
So just remove this test.
================
Comment at: llvm/tools/clang/test/CodeGen/Debug-info-explicitcast.c:19
@@ +18,3 @@
+};
+void foo4(void *p) { ((union U4 *)p)->i++; }
+
----------------
This test doesn't seem to be necessary either - your change doesn't have
anything union-specific. Type building is type building and is fairly well
tested elsewhere - redundant tests just make for longer test times and more
maintenance when we do need to change something that affects the results of
such code.
http://reviews.llvm.org/D2498
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
