> Please separate out the Sema changes from this patch into a separate patch.
Hal, the changes in Sema are required for codegen only. I won't be able to test
them without codegen.
================
Comment at: lib/CodeGen/CGExpr.cpp:3483
@@ +3482,3 @@
+
+bool CodeGenFunction::isTrivialInitializer(const Expr *Init) {
+ if (!Init)
----------------
hfinkel wrote:
> I don't think there is any reason to move this function to a different file.
> You can update its signature in-place. If you want to move it to a different
> file for organizational reasons, please do that in a separate commit.
Ok, I'll return it back
================
Comment at: lib/CodeGen/CGStmtOpenMP.cpp:58
@@ +57,3 @@
+ } else {
+ // Perform element-by-element initialization.
+ QualType ElementTy;
----------------
hfinkel wrote:
> Please extract this into a utility function.
Ok
http://reviews.llvm.org/D5140
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
