----- Original Message ----- > From: "Alexey Bataev" <[email protected]> > To: "a bataev" <[email protected]>, [email protected], [email protected], > [email protected], > [email protected], [email protected], [email protected], > [email protected] > Cc: [email protected] > Sent: Tuesday, September 23, 2014 5:47:21 AM > Subject: Re: [PATCH] [OPENMP] Codegen for threadprivate variables >
[snip] To be clear, regarding these changes below, is either of them separately testable? If so, please go ahead and commit them now with a test. -Hal > ================ > Comment at: lib/Parse/Parser.cpp:627 > @@ -626,4 +626,3 @@ > case tok::annot_pragma_openmp: > - ParseOpenMPDeclarativeDirective(); > - return DeclGroupPtrTy(); > + return ParseOpenMPDeclarativeDirective(); > case tok::annot_pragma_ms_pointers_to_members: > ---------------- > hfinkel wrote: > > Is this a separate change? > Nope, this is required for codegen, without it the declaration is not > passed to codegen consumer. > > ================ > Comment at: lib/Serialization/ASTReaderDecl.cpp:2186 > @@ -2185,3 +2185,3 @@ > isa<ObjCImplDecl>(D) || > - isa<ImportDecl>(D)) > + isa<ImportDecl>(D) || isa<OMPThreadPrivateDecl>(D)) > return true; > ---------------- > hfinkel wrote: > > This is a separate change. > Nope, it's a part of codegen, without this change codegen for > construct loaded from .pch does not work. > > http://reviews.llvm.org/D4002 > > > -- Hal Finkel Assistant Computational Scientist Leadership Computing Facility Argonne National Laboratory _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
