This LGTM, thanks!
- Doug
> On Sep 23, 2014, at 5:03 PM, Ben Langmuir <[email protected]> wrote:
>
> Hi Doug,
>
> As suggested, this patch moves calls to ResolveExceptionSpec out of
> SetDeclDefaulted and into DefineImplicit*. This fixes an assertion failure
> in CodeGen where we were not resolving an exception specification. The one
> bit I’m not sure of is the position of the calls relative to the note that we
> issue inside the DefineImplicit* functions. It seems to work where it is,
> but if I call ResolveExceptionSpec before that diagnostic I change the
> locations of several other diagnostics in the regression tests and drop
> several of these notes. I don’t see any obvious reason for that, and haven’t
> had a chance to try debugging what’s going on.
>
> Ben
>
> <rdar18309639.patch>
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
