================
Comment at: lib/Sema/JumpDiagnostics.cpp:496
@@ -487,1 +495,3 @@
 void JumpScopeChecker::VerifyJumps() {
+  std::map<StringRef, MSAsmStmt*> LabelProvider;
+  for (Stmt *J : Jumps) {
----------------
At a high level, I feel like we shouldn't need this map. It basically reinvents 
the label name lookup that sema is already performing for us.

What if we changed LabelDecl to hold an MSAsmStmt*? Conceptually, we could make 
TheStmt be a Stmt* and getStmt() could be 'return 
dyn_cast_or_null<LabelStmt>(TheStmt);'.

http://reviews.llvm.org/D5516



_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to