LGTM, thanks! > Regarding 'lastprivate' codegen at: lib/CodeGen/CGStmtOpenMP.cpp:67 -- this > will need helper expressions in OMPLastprivateClause (e.g., Copy Constructor > to copy from private var to the non-private), this would be better to do in a > separate patch.
Okay, please make this clear in the comment (and please add an assert, to be removed later, if the code will be functionally-incorrect without this logic). ================ Comment at: lib/Sema/SemaOpenMP.cpp:2597 @@ +2596,3 @@ + + // Choose either 32-bit or 64-bit version. + ExprResult LastIteration = LastIteration64; ---------------- Add "the" before 32-bit http://reviews.llvm.org/D5184 _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
