Hi Jon,

Thanks for the review.

> I'm surprised that the SubArchType isn't being set correctly from the
combination of `-target thumb-none-linux-eabi -mcpu=cortex-m0`. I think the
"right" fix is to track down
> why that's happening and fix it there instead, rather than regressing the
subarch triple stuff back toward a stryingly-typed mess.

Should have loaded more surrounding context into my head when I made this
change, noticed a simpler way of fixing this issue. The problem was calling
getToolChain().getTriple() rather than
getToolChain().ComputeEffectiveClangTriple(..), the later takes into account
the CPU given as well as the architecture.

New patch attached.

Thanks,
Charlie.

Attachment: 0001-Diagnostic-for-munaligned-access-on-v6M-targets.patch
Description: Binary data

_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to