LGTM, thanks!
================
Comment at: lib/CodeGen/CGStmtOpenMP.cpp:128
@@ +127,3 @@
+ }
+
+}
----------------
Extra line.
================
Comment at: lib/Sema/SemaOpenMP.cpp:3381
@@ +3380,3 @@
+ // original variable. The address of the original variable is replaced by
+ // the address of the new private variable in the CodeGen.This new variable
+ // is not added to IdResolver, so the code in the OpenMP region uses
----------------
Missing space before "This".
================
Comment at: lib/Sema/SemaOpenMP.cpp:3386
@@ +3385,3 @@
+ // For arrays generate initializer for single element and replace it by the
+ // original array element on the CodeGen.
+ if (DE->getType()->isArrayType()) {
----------------
on the CodeGen -> in CodeGen
================
Comment at: test/OpenMP/for_firstprivate_messages.cpp:222
@@ -221,2 +221,3 @@
#pragma omp parallel
+
#pragma omp for firstprivate(xa) // OK
----------------
Extra newline?
http://reviews.llvm.org/D5140
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
