In case const auto * deduced type has different meaning (pointer to constant), 
so it doesn’t compile.

On Oct 13, 2014, at 9:16 AM, Nikola Smiljanić <[email protected]> wrote:

> It looks good ignoring two style nitpicks. I'll have more confidence when you 
> add the test for this, code review can stay open until you get to it.
> 
> ================
> Comment at: lib/Sema/SemaTemplate.cpp:6226
> @@ +6225,3 @@
> +  if (isPartialSpecialization) {
> +    auto *const ThisPartialSpec =
> +        static_cast<ClassTemplatePartialSpecializationDecl 
> *>(Specialization);
> ----------------
> const auto *
> 
> ================
> Comment at: lib/Sema/SemaTemplate.cpp:6234
> @@ +6233,3 @@
> +          !DeduceTemplateArguments(ThisPartialSpec, S->getTemplateArgs(), 
> Info)) {
> +        auto *const InstantiatedFrom =
> +            S->getInstantiatedFrom()
> ----------------
> Same here.
> 
> http://reviews.llvm.org/D5744
> 
> 


_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to