================ Comment at: clang-tidy/misc/CMakeLists.txt:18 @@ -20,2 +17,3 @@ clangTidy + clangTidyReadability ) ---------------- djasper wrote: > Hm. I understand that you don't want to create a separate readability at this > point. But leave a comment here, otherwise the layering seems quite confusing. Done.
================ Comment at: clang-tidy/readability/BracesAroundStatementsCheck.h:10 @@ -9,3 +9,3 @@ -#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MISC_BRACES_AROUND_STATEMENTS_CHECK_H -#define LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MISC_BRACES_AROUND_STATEMENTS_CHECK_H +#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_READABILITY_BRACESAROUNDSTATEMENTSCHECK_H +#define LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_READABILITY_BRACESAROUNDSTATEMENTSCHECK_H ---------------- djasper wrote: > Not sure whether this is allowed/desired for LLVM style, but we should fix > the comment on the #endif accordingly. Yeah, the llvm-header-guard check should at least fix existing comments if not add new ones. Its current behavior is slightly harmful. ================ Comment at: clang-tidy/readability/FunctionSize.h:48 @@ -45,2 +47,2 @@ #endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MISC_FUNCTIONSIZE_H ---------------- djasper wrote: > Fix comment. Fixed #endif comments. http://reviews.llvm.org/D5792 _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
