Looks good.
================
Comment at: clang-tidy/ClangTidyOptions.cpp:183
@@ -173,3 +182,3 @@
if (!Result)
- Result = TryReadConfigFile(CurrentPath);
+ Result = TryReadConfigFile(CurrentPath);
----------------
indentation
================
Comment at: clang-tidy/ClangTidyOptions.h:144
@@ +143,3 @@
+ /// return llvm::make_unique<FileOptionsProvider>(GlobalOptions,
+ /// DefaultOptions, OverrideOptions, ConfigHandlers);
+ /// \endcode
----------------
It seems complicated to have to specify all of GlobalOptions, DefaultOptions
and OverrideOptions. Consider adding overloads or something.
nit: indentation ;-)
http://reviews.llvm.org/D5821
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
