Here is the failing code, an example from boost::multiprecision. The boost version is 1.56 (the latest). Compiled with -c -g, nothing special. Maybe you'd like to add this as a test? boost::multiprecision is very demanding code.
Yaron 2014-10-20 19:59 GMT+03:00 David Blaikie <[email protected]>: > > > On Mon, Oct 20, 2014 at 9:32 AM, Yaron Keren <[email protected]> > wrote: > >> Hi David, >> >> Beyond renaming getTypeForDecl(), this revision also introduced >> functionality changes in CGDebugInfo.cpp, >> > > Yep, sorry - I could've separated those patches. > > >> specifically the >> >> if (InstanceMember) { >> >> test was removed, leading to >> >> http://llvm.org/bugs/show_bug.cgi?id=21312 >> >> Was the condition removed by mistake? >> > > Not exactly - I intentionally removed it, but of course causing bugs was a > mistake. > > Do you have a (preferably minimized) reproduction of this crash? > > >> >> Yaron >> >> >> >> 2014-10-17 21:00 GMT+03:00 David Blaikie <[email protected]>: >> >>> Author: dblaikie >>> Date: Fri Oct 17 13:00:12 2014 >>> New Revision: 220060 >>> >>> URL: http://llvm.org/viewvc/llvm-project?rev=220060&view=rev >>> Log: >>> Rename TemplateArgument::getTypeForDecl to getParamTypeForDecl for >>> clarity >>> >>> Code review feedback from Richard Smith on r219900. >>> >>> Modified: >>> cfe/trunk/include/clang/AST/TemplateBase.h >>> cfe/trunk/lib/AST/ASTContext.cpp >>> cfe/trunk/lib/AST/ASTImporter.cpp >>> cfe/trunk/lib/AST/ItaniumMangle.cpp >>> cfe/trunk/lib/AST/MicrosoftMangle.cpp >>> cfe/trunk/lib/CodeGen/CGDebugInfo.cpp >>> cfe/trunk/lib/Serialization/ASTWriter.cpp >>> >>> Modified: cfe/trunk/include/clang/AST/TemplateBase.h >>> URL: >>> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/TemplateBase.h?rev=220060&r1=220059&r2=220060&view=diff >>> >>> ============================================================================== >>> --- cfe/trunk/include/clang/AST/TemplateBase.h (original) >>> +++ cfe/trunk/include/clang/AST/TemplateBase.h Fri Oct 17 13:00:12 2014 >>> @@ -249,7 +249,7 @@ public: >>> return DeclArg.D; >>> } >>> >>> - QualType getTypeForDecl() const { >>> + QualType getParamTypeForDecl() const { >>> assert(getKind() == Declaration && "Unexpected kind"); >>> return QualType::getFromOpaquePtr(DeclArg.QT); >>> } >>> >>> Modified: cfe/trunk/lib/AST/ASTContext.cpp >>> URL: >>> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/ASTContext.cpp?rev=220060&r1=220059&r2=220060&view=diff >>> >>> ============================================================================== >>> --- cfe/trunk/lib/AST/ASTContext.cpp (original) >>> +++ cfe/trunk/lib/AST/ASTContext.cpp Fri Oct 17 13:00:12 2014 >>> @@ -4099,7 +4099,7 @@ ASTContext::getCanonicalTemplateArgument >>> >>> case TemplateArgument::Declaration: { >>> ValueDecl *D = >>> cast<ValueDecl>(Arg.getAsDecl()->getCanonicalDecl()); >>> - return TemplateArgument(D, Arg.getTypeForDecl()); >>> + return TemplateArgument(D, Arg.getParamTypeForDecl()); >>> } >>> >>> case TemplateArgument::NullPtr: >>> >>> Modified: cfe/trunk/lib/AST/ASTImporter.cpp >>> URL: >>> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/ASTImporter.cpp?rev=220060&r1=220059&r2=220060&view=diff >>> >>> ============================================================================== >>> --- cfe/trunk/lib/AST/ASTImporter.cpp (original) >>> +++ cfe/trunk/lib/AST/ASTImporter.cpp Fri Oct 17 13:00:12 2014 >>> @@ -2094,7 +2094,7 @@ ASTNodeImporter::ImportTemplateArgument( >>> case TemplateArgument::Declaration: { >>> ValueDecl *FromD = From.getAsDecl(); >>> if (ValueDecl *To = cast_or_null<ValueDecl>(Importer.Import(FromD))) >>> - return TemplateArgument(To, From.getTypeForDecl()); >>> + return TemplateArgument(To, From.getParamTypeForDecl()); >>> return TemplateArgument(); >>> } >>> >>> >>> Modified: cfe/trunk/lib/AST/ItaniumMangle.cpp >>> URL: >>> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/ItaniumMangle.cpp?rev=220060&r1=220059&r2=220060&view=diff >>> >>> ============================================================================== >>> --- cfe/trunk/lib/AST/ItaniumMangle.cpp (original) >>> +++ cfe/trunk/lib/AST/ItaniumMangle.cpp Fri Oct 17 13:00:12 2014 >>> @@ -3403,7 +3403,7 @@ void CXXNameMangler::mangleTemplateArg(T >>> // and pointer-to-function expressions are represented as a >>> declaration not >>> // an expression. We compensate for it here to produce the correct >>> mangling. >>> ValueDecl *D = A.getAsDecl(); >>> - bool compensateMangling = !A.getTypeForDecl()->isReferenceType(); >>> + bool compensateMangling = >>> !A.getParamTypeForDecl()->isReferenceType(); >>> if (compensateMangling) { >>> Out << 'X'; >>> mangleOperatorName(OO_Amp, 1); >>> >>> Modified: cfe/trunk/lib/AST/MicrosoftMangle.cpp >>> URL: >>> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/MicrosoftMangle.cpp?rev=220060&r1=220059&r2=220060&view=diff >>> >>> ============================================================================== >>> --- cfe/trunk/lib/AST/MicrosoftMangle.cpp (original) >>> +++ cfe/trunk/lib/AST/MicrosoftMangle.cpp Fri Oct 17 13:00:12 2014 >>> @@ -1139,7 +1139,7 @@ void MicrosoftCXXNameMangler::mangleTemp >>> else >>> mangle(FD, "$1?"); >>> } else { >>> - mangle(ND, TA.getTypeForDecl()->isReferenceType() ? "$E?" : >>> "$1?"); >>> + mangle(ND, TA.getParamTypeForDecl()->isReferenceType() ? "$E?" : >>> "$1?"); >>> } >>> break; >>> } >>> >>> Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp >>> URL: >>> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGDebugInfo.cpp?rev=220060&r1=220059&r2=220060&view=diff >>> >>> ============================================================================== >>> --- cfe/trunk/lib/CodeGen/CGDebugInfo.cpp (original) >>> +++ cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Fri Oct 17 13:00:12 2014 >>> @@ -1255,32 +1255,29 @@ CollectTemplateParams(const TemplatePara >>> } break; >>> case TemplateArgument::Declaration: { >>> const ValueDecl *D = TA.getAsDecl(); >>> - bool InstanceMember = D->isCXXInstanceMember(); >>> - QualType T = TA.getTypeForDecl(); >>> + QualType T = TA.getParamTypeForDecl(); >>> llvm::DIType TTy = getOrCreateType(T, Unit); >>> llvm::Value *V = nullptr; >>> // Variable pointer template parameters have a value that is the >>> address >>> // of the variable. >>> - if (const VarDecl *VD = dyn_cast<VarDecl>(D)) >>> + if (const auto *VD = dyn_cast<VarDecl>(D)) >>> V = CGM.GetAddrOfGlobalVar(VD); >>> // Member function pointers have special support for building >>> them, though >>> // this is currently unsupported in LLVM CodeGen. >>> - if (InstanceMember) { >>> - if (const CXXMethodDecl *method = dyn_cast<CXXMethodDecl>(D)) >>> + else if (const auto *method = dyn_cast<CXXMethodDecl>(D)) >>> V = CGM.getCXXABI().EmitMemberPointer(method); >>> - } else if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(D)) >>> + else if (const auto *FD = dyn_cast<FunctionDecl>(D)) >>> V = CGM.GetAddrOfFunction(FD); >>> // Member data pointers have special handling too to compute the >>> fixed >>> // offset within the object. >>> - if (isa<FieldDecl>(D) || isa<IndirectFieldDecl>(D)) { >>> + else if (const auto *MPT = >>> dyn_cast<MemberPointerType>(T.getTypePtr())) { >>> // These five lines (& possibly the above member function >>> pointer >>> // handling) might be able to be refactored to use similar code >>> in >>> // CodeGenModule::getMemberPointerConstant >>> uint64_t fieldOffset = CGM.getContext().getFieldOffset(D); >>> CharUnits chars = >>> CGM.getContext().toCharUnitsFromBits((int64_t) fieldOffset); >>> - V = CGM.getCXXABI().EmitMemberDataPointer( >>> - cast<MemberPointerType>(T.getTypePtr()), chars); >>> + V = CGM.getCXXABI().EmitMemberDataPointer(MPT, chars); >>> } >>> llvm::DITemplateValueParameter TVP = >>> DBuilder.createTemplateValueParameter(TheCU, Name, TTy, >>> >>> Modified: cfe/trunk/lib/Serialization/ASTWriter.cpp >>> URL: >>> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Serialization/ASTWriter.cpp?rev=220060&r1=220059&r2=220060&view=diff >>> >>> ============================================================================== >>> --- cfe/trunk/lib/Serialization/ASTWriter.cpp (original) >>> +++ cfe/trunk/lib/Serialization/ASTWriter.cpp Fri Oct 17 13:00:12 2014 >>> @@ -5372,7 +5372,7 @@ void ASTWriter::AddTemplateArgument(cons >>> break; >>> case TemplateArgument::Declaration: >>> AddDeclRef(Arg.getAsDecl(), Record); >>> - AddTypeRef(Arg.getTypeForDecl(), Record); >>> + AddTypeRef(Arg.getParamTypeForDecl(), Record); >>> break; >>> case TemplateArgument::NullPtr: >>> AddTypeRef(Arg.getNullPtrType(), Record); >>> >>> >>> _______________________________________________ >>> cfe-commits mailing list >>> [email protected] >>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits >>> >> >> >
// Copyright Christopher Kormanyos 2013. // Copyright Paul A. Bristow 2013. // Copyright John Maddock 2013. // Distributed under the Boost Software License, Version 1.0. // (See accompanying file LICENSE_1_0.txt or // copy at http://www.boost.org/LICENSE_1_0.txt). #ifdef _MSC_VER # pragma warning (disable : 4512) // assignment operator could not be generated. # pragma warning (disable : 4996) // assignment operator could not be generated. #endif #include <iostream> #include <limits> #include <vector> #include <algorithm> #include <iomanip> #include <iterator> // Weisstein, Eric W. "Bessel Function Zeros." From MathWorld--A Wolfram Web Resource. // http://mathworld.wolfram.com/BesselFunctionZeros.html // Test values can be calculated using [@wolframalpha.com WolframAplha] // See also http://dlmf.nist.gov/10.21 //[airy_zeros_example_1 /*`This example demonstrates calculating zeros of the Airy functions. It also shows how Boost.Math and Boost.Multiprecision can be combined to provide a many decimal digit precision. For 50 decimal digit precision we need to include */ #include <boost/multiprecision/cpp_dec_float.hpp> /*`and a `typedef` for `float_type` may be convenient (allowing a quick switch to re-compute at built-in `double` or other precision) */ typedef boost::multiprecision::cpp_dec_float_50 float_type; //`To use the functions for finding zeros of the functions we need #include <boost/math/special_functions/airy.hpp> /*`This example shows obtaining both a single zero of the Airy functions, and then placing multiple zeros into a container like `std::vector` by providing an iterator. The signature of the single-value Airy Ai function is: template <class T> T airy_ai_zero(unsigned m); // 1-based index of the zero. The signature of multiple zeros Airy Ai function is: template <class T, class OutputIterator> OutputIterator airy_ai_zero( unsigned start_index, // 1-based index of the zero. unsigned number_of_zeros, // How many zeros to generate. OutputIterator out_it); // Destination for zeros. There are also versions which allows control of the __policy_section for error handling and precision. template <class T, class OutputIterator, class Policy> OutputIterator airy_ai_zero( unsigned start_index, // 1-based index of the zero. unsigned number_of_zeros, // How many zeros to generate. OutputIterator out_it, // Destination for zeros. const Policy& pol); // Policy to use. */ //] [/airy_zeros_example_1] int main() { try { //[airy_zeros_example_2 /*`[tip It is always wise to place code using Boost.Math inside `try'n'catch` blocks; this will ensure that helpful error messages are shown when exceptional conditions arise.] First, evaluate a single Airy zero. The precision is controlled by the template parameter `T`, so this example has `double` precision, at least 15 but up to 17 decimal digits (for the common 64-bit double). */ double aiz1 = boost::math::airy_ai_zero<double>(1); std::cout << "boost::math::airy_ai_zero<double>(1) = " << aiz1 << std::endl; double aiz2 = boost::math::airy_ai_zero<double>(2); std::cout << "boost::math::airy_ai_zero<double>(2) = " << aiz2 << std::endl; double biz3 = boost::math::airy_bi_zero<double>(3); std::cout << "boost::math::airy_bi_zero<double>(3) = " << biz3 << std::endl; /*`Other versions of `airy_ai_zero` and `airy_bi_zero` allow calculation of multiple zeros with one call, placing the results in a container, often `std::vector`. For example, generate and display the first five `double` roots [@http://mathworld.wolfram.com/AiryFunctionZeros.html Wolfram Airy Functions Zeros]. */ unsigned int n_roots = 5U; std::vector<double> roots; boost::math::airy_ai_zero<double>(1U, n_roots, std::back_inserter(roots)); std::cout << "airy_ai_zeros:" << std::endl; std::copy(roots.begin(), roots.end(), std::ostream_iterator<double>(std::cout, "\n")); /*`The first few real roots of Ai(x) are approximately -2.33811, -4.08795, -5.52056, -6.7867144, -7.94413, -9.02265 ... Or we can use Boost.Multiprecision to generate 50 decimal digit roots. We set the precision of the output stream, and show trailing zeros to display a fixed 50 decimal digits. */ std::cout.precision(std::numeric_limits<float_type>::digits10); // float_type has 50 decimal digits. std::cout << std::showpoint << std::endl; // Show trailing zeros too. unsigned int m = 1U; float_type r = boost::math::airy_ai_zero<double>(1U); // 1st root. std::cout << "boost::math::airy_bi_zero<float_type>(" << m << ") = " << r << std::endl; r = boost::math::airy_ai_zero<float_type>(1U); // 1st root. std::cout << "boost::math::airy_bi_zero<float_type>(" << m << ") = " << r << std::endl; m = 7U; r = boost::math::airy_bi_zero<float_type>(7U); // 7th root. std::cout << "boost::math::airy_bi_zero<float_type>(" << m << ") = " << r << std::endl; std::vector<float_type> zeros; boost::math::airy_ai_zero<float_type>(1U, 3, std::back_inserter(zeros)); std::cout << "airy_ai_zeros:" << std::endl; // Print the roots to the output stream. std::copy(zeros.begin(), zeros.end(), std::ostream_iterator<float_type>(std::cout, "\n")); //] [/airy_zeros_example_2] } catch (std::exception ex) { std::cout << "Thrown exception " << ex.what() << std::endl; } } // int main() /* Output: Description: Autorun "J:\Cpp\big_number\Debug\airy_zeros_example.exe" boost::math::airy_ai_zero<double>(1) = -2.33811 boost::math::airy_ai_zero<double>(2) = -4.08795 boost::math::airy_bi_zero<double>(3) = -4.83074 airy_ai_zeros: -2.33811 -4.08795 -5.52056 -6.78671 -7.94413 boost::math::airy_bi_zero<float_type>(1) = -2.3381074104597665552773833042010664939880371093750 boost::math::airy_bi_zero<float_type>(1) = -2.3381074104597670384891972524467354406385502908783 boost::math::airy_bi_zero<float_type>(7) = -9.5381943793462388866329885451560196208390720763825 airy_ai_zeros: -2.3381074104597670384891972524467354406385502908783 -4.0879494441309706166369887014573910602247646991085 -5.5205598280955510591298555129312935737972142806175 */
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
