================
Comment at: lib/Driver/WindowsToolChain.cpp:220
@@ +219,3 @@
+// system (as reported by the registry).
+bool Windows::getVisualStudioBinariesFolder(const char *clangProgramPath,
+ std::string &path) const {
----------------
I don't think we need to sink this logic into the toolchain, we can probably
keep it local to the fallback code, just changing the order of the check for
the VS install dir to come after we've done the PATH search.
================
Comment at: lib/Driver/WindowsToolChain.cpp:226
@@ +225,3 @@
+ path = vcinstalldir;
+ path = path.substr(0, path.find("\\VC"));
+ return true;
----------------
This doesn't seem right, we need the path to VS/VC/bin or VS/VC/bin/amd64. I
don't think we need to have this first case.
http://reviews.llvm.org/D5892
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
