On Wed, Oct 22, 2014 at 5:08 PM, David Blaikie <[email protected]> wrote: > > > On Wed, Oct 22, 2014 at 2:01 PM, Aaron Ballman <[email protected]> > wrote: >> >> On Wed, Oct 22, 2014 at 4:56 PM, David Blaikie <[email protected]> wrote: >> > Is a CompoundStatement's start/end loc ever different from lbrace/rbrace >> > location? (maybe when it's a compound statement without braces? But that >> > can >> > never occur in this part of the AST, right) >> >> It appears to be possible because you can call setLBracLoc (thank >> goodness we left the "e" off there...), but that looks to only be >> called from ASTReader, >> >> > If it isn't, then the if/else >> > LBrace/RBrace bit could be omitted. >> >> There's no relationship between compound statements and function try >> block statements, so I'm not certain how we would omit the if/else. > > > Not sure I follow - but CompoundStmt and CXXTryStmt are both Stmts and all > Stmts have getLocStart/End, right? At least that's my theory...
Oh, hey, would you look at that? It does, and I was simply not seeing it when I looked. Yes, that's much more clean -- attached patch uses that approach. Thanks! ~Aaron
FunctionTryBlockv2.patch
Description: Binary data
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
