On Wed, Oct 22, 2014 at 6:03 PM, Richard Smith <[email protected]>
wrote:

> Author: rsmith
> Date: Wed Oct 22 20:03:45 2014
> New Revision: 220456
>
> URL: http://llvm.org/viewvc/llvm-project?rev=220456&view=rev
> Log:
> Fix covered-switch warning.
>
> Modified:
>     cfe/trunk/lib/Lex/ModuleMap.cpp
>
> Modified: cfe/trunk/lib/Lex/ModuleMap.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Lex/ModuleMap.cpp?rev=220456&r1=220455&r2=220456&view=diff
>
> ==============================================================================
> --- cfe/trunk/lib/Lex/ModuleMap.cpp (original)
> +++ cfe/trunk/lib/Lex/ModuleMap.cpp Wed Oct 22 20:03:45 2014
> @@ -2305,6 +2305,7 @@ bool ModuleMapParser::parseModuleMapFile
>      case MMToken::RequiresKeyword:
>      case MMToken::Star:
>      case MMToken::StringLiteral:
> +    case MMToken::TextualKeyword:
>

Probably not, but just checking: is there missing test coverage here? (that
would exercise this case in the switch)


>      case MMToken::UmbrellaKeyword:
>      case MMToken::UseKeyword:
>        Diags.Report(Tok.getLocation(), diag::err_mmap_expected_module);
>
>
> _______________________________________________
> cfe-commits mailing list
> [email protected]
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to