================ Comment at: include/clang/ASTMatchers/ASTMatchers.h:156 @@ +155,3 @@ + +/// \brief Matches AST nodes that were expanded within the main-file +/// ---------------- Nit: "." at the end of sentences (here and below).
================ Comment at: include/clang/ASTMatchers/ASTMatchers.h:190 @@ +189,3 @@ +/// Usable as: Matcher<Decl>, Matcher<Stmt>, Matcher<TypeLoc> +AST_POLYMORPHIC_MATCHER(isInSystemHeader, + AST_POLYMORPHIC_SUPPORTED_TYPES_3(Decl, Stmt, ---------------- Also rename to isExpansionInSystemHeader? ================ Comment at: include/clang/Lex/PreprocessorOptions.h:14 @@ -13,2 +13,3 @@ #include "clang/Basic/SourceLocation.h" +#include "clang/Tooling/Tooling.h" #include "llvm/ADT/IntrusiveRefCntPtr.h" ---------------- We don't want the Lexer to depend on Tooling - that's the wrong way around... ================ Comment at: include/clang/Lex/PreprocessorOptions.h:99 @@ -101,1 +98,3 @@ + /// the system and gives them the contents of other files on the system + tooling::FileContentMappings RemappedFiles; ---------------- I'd just leave this without the typedef for now... http://reviews.llvm.org/D4283 _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
