On Thu, Oct 30, 2014 at 12:54 PM, Zachary Turner <[email protected]> wrote: > This has been submitted > > ================ > Comment at: lib/Driver/Tools.cpp:7825 > @@ +7824,3 @@ > + llvm::sys::path::append(VSDir, Exe); > + if (llvm::sys::fs::can_execute(VSDir.c_str())) > + return VSDir.str(); > ---------------- > hans wrote: >> nit: I'd just use VSDir.str(). Same for FilePath below. > I did use VSDir.str(), did you mean you'd just use VSDir? Won't compile, > there's no implicit conversion from SmallString to Twine.
I meant preferring VSDir.str() over VSDir.c_str(). In the patch it looked like some lines still had the latter. Anyway, not a big deal. _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
