Hi Rafael,
Rafael Espíndola <[email protected]> wrote on 11/07/2014 12:25:36
PM:
> From: Rafael Espíndola <[email protected]>
> To: Samuel F Antao/Watson/IBM@IBMUS
> Cc: llvm cfe <[email protected]>
> Date: 11/07/2014 12:25 PM
> Subject: Re: [PATCH] Fix clash of gcc toolchains in hexagon driver
> regression tests
>
> + std::string gcc_toolchain = getGCCToolchainDir(Args);
>
> There is talk of using this style of variable names, but for now we
> are still with CamelCase for variables.
>
> LGTM with the variable name changed.
I've fixed the variable name. Committed in r221535.
Thanks again,
Samuel
>
>
> On 6 November 2014 18:37, Samuel F Antao <[email protected]> wrote:
> > Hi Rafael,
> >
> > Sorry about that. Not sure what I did wrong... Find attached the new
patch.
> > I doubled-checked this time.
> >
> > Thanks!
> > Samuel
> >
> > (See attached file: clang_hexagon_fix.patch)
> >
> > Rafael Espíndola <[email protected]> wrote on 11/05/2014
05:40:07
> > PM:
> >
> >> From: Rafael Espíndola <[email protected]>
> >> To: Samuel F Antao/Watson/IBM@IBMUS
> >> Cc: llvm cfe <[email protected]>
> >> Date: 11/05/2014 05:40 PM
> >> Subject: Re: [PATCH] Fix clash of gcc toolchains in hexagon driver
> >> regression tests
> >>
> >> On 5 November 2014 16:29, Samuel F Antao <[email protected]> wrote:
> >> > Hi Rafael,
> >> >
> >> > Thanks for the review. I followed your suggestion and used
> >> > getGCCToolchainDir instead. git-clang-format seems not to
complainabout
> >> > any
> >> > issues now.
> >>
> >> That is odd. Running "git-clang-format master" after applying your
> >> patch to a branch produces the attached patch.
> >>
> >> Cheers,
> >> Rafael
> >> [attachment "t.patch" deleted by Samuel F Antao/Watson/IBM]
>
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
