(it's a bit easier if you include the test in the same patch file - also you can use Phabricator if you like - some reviewers perefer it)
Since you've got the loop there for seeing through multiple levels of pointer, should you have a test case that exercises that on a > 1 level of depth? Demonstrate that we warn on both levels (if that's the right thing to do?)? Optionally (probably in a separate follow-up patch) you could add a note with a fixit to include the missing consts. On Tue, Nov 11, 2014 at 10:58 AM, Roman Divacky <[email protected]> wrote: > Hi, > > I implemented -Wcast-qual. The patch is actually quite short (attached + a > test > case). > > This fixes #13772 and also note that -Wcast-qual is used in llvm build > itself. > > Is this ok to be commited? Thanks > > Roman > > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
