Isn’t the line I posted semantically equivalent to the snippet from the diff ?
If the StringRef returned from getWarningOptionForDiag is empty then the 
“WarningOption” string variable will be set to empty.

> On Nov 13, 2014, at 2:54 PM, Steven Wu <[email protected]> wrote:
> 
> Not all Diagnostics are warnings and not all warnings has a flag. If the flag 
> is not applicable, then this field is not generated.
> 
>> On Nov 13, 2014, at 2:47 PM, Argyrios Kyrtzidis <[email protected] 
>> <mailto:[email protected]>> wrote:
>> 
>> DE.WarningOption = DiagnosticIDs::getWarningOptionForDiag(DE.DiagnosticID);
>> 
> 
> _______________________________________________
> cfe-commits mailing list
> [email protected]
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to