On czw, 2014-11-13 at 19:09 -0800, Richard Smith wrote:
> On Thu, Nov 13, 2014 at 10:36 AM, Tomasz Miąsko
> <[email protected]> wrote:
>         Indeed, something like "if (!member) return
>         mangleExpression(base)", would be
>         really nice, but the problem is that we need a member name
>         from outermost
>         MemberExpr generated from IndirectFieldDecl, and isArrow from
>         innermost
>         MemberExpr generated from IndirectFieldDecl.
> 
> 
> Good point =)
>  
>         I updated the code to skip over all bases whose types are
>         anonymous structs or
>         unions, though I will mention that first version that relied
>         on empty
>         identifiers would also work.
> 
> 
> Thanks, LGTM. Do you have an SVN account, or do you need someone to
> commit this for you?
>  

I don't have commit access, could you commit this for me?

Thanks,
Tomasz


>         http://reviews.llvm.org/D5997
>         
>         Files:
>           lib/AST/ItaniumMangle.cpp
>           test/CodeGenCXX/mangle-exprs.cpp
>         
> 
> 


_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to