================
Comment at: test/test_vector1.cpp:218
@@ -217,3 +219,2 @@
two = __cxxabiv1::__cxa_vec_new2( 10, 40, 8, throw_construct,
throw_destruct, my_alloc2, my_dealloc2 );
- three = __cxxabiv1::__cxa_vec_new3( 10, 40, 8, throw_construct,
throw_destruct, my_alloc2, my_dealloc3 );
}
----------------
jroelofs wrote:
> I may have missed the conversation about this one, but why are you deleting
> this part of the test?
>
> I don't fee comfortable signing off on the changes in this file as I'm not
> familiar with __cxa_vec_new*.
The test seems to check that __cxa_vec_delete deallocates the vector even if
one of the destructors throws. The call to `__cxa_vec_delete3` is not called
because `__cxa_vec_delete2` is expected to throw. To check this `assert(false)`
is now used instead of the side effects of `__cxa_vec_delete3`.
@mclow seems to have written the test so I'll ask him to sign off on it.
http://reviews.llvm.org/D6281
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
