On Fri, Nov 21, 2014 at 5:01 PM, Richard Smith <[email protected]> wrote:
> On Fri, Nov 21, 2014 at 3:56 PM, David Majnemer <[email protected]> > wrote: > >> Author: majnemer >> Date: Fri Nov 21 17:56:50 2014 >> New Revision: 222591 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=222591&view=rev >> Log: >> MS ABI: Mangle u8 string literals >> >> UTF8 string literals are mangled just like ASCII string literals. >> >> Modified: >> cfe/trunk/lib/AST/MicrosoftMangle.cpp >> cfe/trunk/test/CodeGenCXX/mangle-ms-string-literals.cpp >> >> Modified: cfe/trunk/lib/AST/MicrosoftMangle.cpp >> URL: >> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/MicrosoftMangle.cpp?rev=222591&r1=222590&r2=222591&view=diff >> >> ============================================================================== >> --- cfe/trunk/lib/AST/MicrosoftMangle.cpp (original) >> +++ cfe/trunk/lib/AST/MicrosoftMangle.cpp Fri Nov 21 17:56:50 2014 >> @@ -338,7 +338,8 @@ bool MicrosoftMangleContextImpl::shouldM >> >> bool >> MicrosoftMangleContextImpl::shouldMangleStringLiteral(const >> StringLiteral *SL) { >> - return SL->isAscii() || SL->isWide() || SL->isUTF16() || SL->isUTF32(); >> + return SL->isAscii() || SL->isWide() || SL->isUTF8() || SL->isUTF16() >> || >> + SL->isUTF32(); >> } >> > > Looks like "return true;" to me. > It doesn't return true for isPascal. > > >> void MicrosoftCXXNameMangler::mangle(const NamedDecl *D, StringRef >> Prefix) { >> >> Modified: cfe/trunk/test/CodeGenCXX/mangle-ms-string-literals.cpp >> URL: >> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/mangle-ms-string-literals.cpp?rev=222591&r1=222590&r2=222591&view=diff >> >> ============================================================================== >> --- cfe/trunk/test/CodeGenCXX/mangle-ms-string-literals.cpp (original) >> +++ cfe/trunk/test/CodeGenCXX/mangle-ms-string-literals.cpp Fri Nov 21 >> 17:56:50 2014 >> @@ -719,6 +719,8 @@ const wchar_t *LongWideString = L"012345 >> // CHECK: @"\01??_C@_1EK@KFPEBLPK >> @?$AA0?$AA1?$AA2?$AA3?$AA4?$AA5?$AA6?$AA7?$AA8?$AA9?$AA0?$AA1?$AA2?$AA3?$AA4?$AA5?$AA6?$AA7?$AA8?$AA9?$AA0?$AA1?$AA2?$AA3?$AA4?$AA5?$AA6?$AA7?$AA8?$AA9?$AAA?$AAB@ >> " >> const wchar_t *UnicodeLiteral = L"\ud7ff"; >> // CHECK: @"\01??_C@_13IIHIAFKH@?W?$PP?$AA?$AA@" >> +const char *U8Literal = u8"hi"; >> +// CHECK: @"\01??_C@_02PCEFGMJL@hi?$AA@" >> const char16_t *U16Literal = u"hi"; >> // CHECK: @"\01??_C@_05OMLEGLOC@h?$AAi?$AA?$AA?$AA@" >> const char32_t *U32Literal = U"hi"; >> >> >> _______________________________________________ >> cfe-commits mailing list >> [email protected] >> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits >> > >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
