On Mon, Nov 24, 2014 at 12:47 PM, David Blaikie <[email protected]> wrote:
> > > On Mon, Nov 24, 2014 at 12:14 PM, Saleem Abdulrasool < > [email protected]> wrote: > >> Author: compnerd >> Date: Mon Nov 24 14:14:26 2014 >> New Revision: 222679 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=222679&view=rev >> Log: >> CodeGen: use a range-based for loop >> >> Convert a debug assertion into a range-based loop form. NFC. >> >> Modified: >> cfe/trunk/lib/CodeGen/CGCall.cpp >> >> Modified: cfe/trunk/lib/CodeGen/CGCall.cpp >> URL: >> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGCall.cpp?rev=222679&r1=222678&r2=222679&view=diff >> >> ============================================================================== >> --- cfe/trunk/lib/CodeGen/CGCall.cpp (original) >> +++ cfe/trunk/lib/CodeGen/CGCall.cpp Mon Nov 24 14:14:26 2014 >> @@ -447,9 +447,8 @@ CodeGenTypes::arrangeLLVMFunctionInfo(Ca >> FunctionType::ExtInfo info, >> RequiredArgs required) { >> #ifndef NDEBUG >> - for (ArrayRef<CanQualType>::const_iterator >> - I = argTypes.begin(), E = argTypes.end(); I != E; ++I) >> - assert(I->isCanonicalAsParam()); >> + for (const auto &AT : argTypes) >> + assert(AT.isCanonicalAsParam()); >> #endif >> > > How about: > > assert(std::all_of(argTypes.begin(), argTypes.end(), > std::mem_fun_ref(&CanQualType::isCanonicalAsParam)); > As far as I am concerned, strictly superior :-). I'll adjust it accordingly. > ? > > >> >> unsigned CC = ClangCallConvToLLVMCallConv(info.getCC()); >> >> >> _______________________________________________ >> cfe-commits mailing list >> [email protected] >> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits >> > > -- Saleem Abdulrasool compnerd (at) compnerd (dot) org
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
