On 11/27/2014 8:12 AM, Ribulous Barnulous wrote:
Great. Anything else I need to do to get committed?
On Tue, Nov 25, 2014 at 11:54 PM, Sahasrabuddhe, Sameer
<[email protected] <mailto:[email protected]>>
wrote:
Thanks. LGTM!
Since nobody has submitted the patch so far, I could take a stab at it.
Please holler if that is unexpected!
I have commit access to the svn repo, which was originally meant for
submitting minor fixes to Polly. I never needed to submit anything so
this would be my first time. I checked out llvm trunk and cfe trunk, and
then ran "ninja check-all" with the patch applied. Is there any other
sanity check to be done?
The commit message will be:
<msg>
Always emit kernel arg info for SPIR.
http://llvm.org/bugs/show_bug.cgi?id=21555
Currently, kernel argument metadata is omitted unless the
"-cl-kernel-arg-info" option is specified. But the SPIR 1.2 spec
requires that all metadata except kernel_arg_name should always be
emitted, and kernel_arg_name is only emitted when
"-cl-kernel-arg-info" is specified.
Patch contributed by Ribulous Barnulous.
</msg>
BTW, is "Ribulous Barnulous" the same as "Ryan Burn" from the bug? If
so, which name should go in the commit?
Sameer.
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
