I played with this some more, and determined that the best place to load the module map files is from the frontend rather than from header search; I modified your patch to do that and landed it as r223561.
On Mon, Nov 24, 2014 at 6:00 PM, John Thompson < [email protected]> wrote: > Sorry, I missed the hard tab, braces, and etc. However, if I remove the > clearing of the ModuleMapFiles member, one of the tests, > Modules/modular_maps.cpp segfaults deep in some AST code, but only on > running the test on Linux, so it's kind of hard to debug, not being much of > a Linux/gdb guy. Did I put this code in the right place? I was kind of > uncomfortable putting it in the HeaderSearch constructor, but it is a > convenient place, since HeaderSearch has convenient members. I don't see > any other references to the ModuleMapFiles member, so I'm not sure what > triggers the segfault only on Linux, unless it's some memory-stomping or > post-free-write issue somewhere. > > http://reviews.llvm.org/D6324 > > Files: > include/clang/Basic/DiagnosticLexKinds.td > lib/Lex/HeaderSearch.cpp > test/Modules/pr21217.cpp >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
