+1. On Fri, Dec 5, 2014 at 4:35 PM, Jordan Rose <[email protected]> wrote:
> +1 from me, and I like the name choice. > > > On Dec 5, 2014, at 15:41, Robinson, Paul < > [email protected]> wrote: > > > > This seemed a *little* too intricate to commit directly even if it is > NFC. > > Also gives everyone a chance to disagree with the name choices. :-) > > > > This is a followup to a GetSVN.cmake change; Sean Silva and Jordan Rose > > asked to have the name of the SVN_REVISION/SVN_REPOSITORY symbols > changed. > > This requires changing both the Makefile and CMakeLists.txt so they both > > generate the same symbol name, and Version.cpp which is the only > consumer. > > > > The header generated by CMakeLists.txt/GetSVN.cmake used to look like > this: > > > > #define LLVM_REVISION "223538" > > #define LLVM_REPOSITORY "http://llvm.org/svn/llvm-project/llvm/trunk"; > > #define SVN_REVISION "223538" > > #define SVN_REPOSITORY "http://llvm.org/svn/llvm-project/cfe/trunk"; > > > > and now looks like this: > > > > #define LLVM_REVISION "223538" > > #define LLVM_REPOSITORY "http://llvm.org/svn/llvm-project/llvm/trunk"; > > #define CLANG_REVISION "223538" > > #define CLANG_REPOSITORY "http://llvm.org/svn/llvm-project/cfe/trunk"; > > > > --paulr > > <svn_revision.diff> > > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
