Generally speaking, I am strongly in favor of libc++ isolating its functionality from features which are so varying in quality from system to system as locales. Where it is reasonable from a maintenance and support perspective, I would much rather than libc++ simple implement and provide the desired behavior from first principles.
On Thu, Dec 11, 2014 at 2:17 PM, Yaron Keren <[email protected]> wrote: > Last time I looked, libc++ on Windows uses an undocumented table in > MSVCRT.DLL for this purpose. > It would be much better to use a built-in table. > > > 2014-12-11 14:42 GMT+02:00 Ed Schouten <[email protected]>: > >> Hi Joerg, >> >> 2014-12-11 12:40 GMT+01:00 Joerg Sonnenberger <[email protected]>: >> >> + return (c >= L'a' && c <= L'z') ? c - L'a' + L'A' : c; >> > >> > Regression? >> >> Could you please clarify? >> >> > Please properly use the system table, no need to waste space. >> >> That would be the opposite of what we're trying to achieve. Please >> read up on the bug mentioned earlier in this discussion, which points >> out the problems with using the system table. >> >> Thanks, >> -- >> Ed Schouten <[email protected]> >> _______________________________________________ >> cfe-commits mailing list >> [email protected] >> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits >> > > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
