+  if (const EnumType* ET = dyn_cast<EnumType>(T)) {

* on the right please, and use T->getAs<EnumType>() in case there is type
sugar here (there probably can't be for a TemplateArgument that's been
resolved to an integral value, but dyn_cast on a type is a red flag that we
don't need here).

Otherwise, LGTM, thanks!

On Thu, Dec 11, 2014 at 8:28 PM, Will Wilson <[email protected]> wrote:

> Hi Richard,
>
> Here's a simple patch that improves pretty printing for templates args
> specialized to enum constants. If an enum constant isn't available to
> represent the value it falls back on printing the integer value.
>
> Tested against latest trunk and includes a new test case and a updated
> existing test case.
>
> Let me know if it looks good to go...
>
> Cheers,
> Will.
>
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to