In http://reviews.llvm.org/D6259#101418, @ABataev wrote:

> > I'm thinking we should probably split the rename of refersToEnclosingLocal 
> > -> refersToCapturedVariable into a separate patch, though.
>
>
> I think we should keep it in this patch, because we're changing the meaning 
> of this flag.


We're expanding the meaning of the flag.  It's good to stage changes like this 
— it means that you can say definitively that the larger and more 
invasive-looking patch is a non-functional change, which is really useful for 
people reviewing the commit history.  Please do this; I know it's a little 
annoying to do it after you've already got a unified patch, but it's the right 
thing to do.

If you split it, it looks ready to go.


http://reviews.llvm.org/D6259

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/



_______________________________________________
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to