> On Jan 2, 2015, at 7:10 AM, Richard Smith <[email protected]> wrote:
> On Tue, Dec 16, 2014 at 12:01 AM, Alexey Bataev <[email protected]
> <mailto:[email protected]>> wrote:
> Author: abataev
> Date: Tue Dec 16 02:01:48 2014
> New Revision: 224329
>
> URL: http://llvm.org/viewvc/llvm-project?rev=224329&view=rev
> <http://llvm.org/viewvc/llvm-project?rev=224329&view=rev>
> Log:
> Renamed RefersToEnclosingLocal bitfield to RefersToCapturedVariable.
> Bitfield RefersToEnclosingLocal of Stmt::DeclRefExprBitfields renamed to
> RefersToCapturedVariable to reflect latest changes introduced in commit
> 224323. Also renamed method Expr::refersToEnclosingLocal() to
> Expr::refersToCapturedVariable() and comments for constant arguments.
> No functional changes.
>
> This seems like a bad idea for me. It's incorrect: for a lambda, the flag
> means that the DeclRefExpr refers to an enclosing local, and does *not* imply
> that the variable is necessarily captured. This confusion has already led to
> a bug (fixed in r225060).
If that’s actually a useful property to track, I have no complaint about
tracking the two things separately. I don’t think DRE is short of bits.
John.
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
