In http://reviews.llvm.org/D6881#106467, @EricWF wrote:
> Just a nit, could we give the python module a more descriptive name than > `test`? This change will make it possible to share libc++'s configuration and > format with libc++abi. When using it in libc++abi the name `test` will be > quite vague. > > I'm also not sure I like the libcxx root being a python module. What is the > benefit of that? Woops, I misunderstood the layout of this patch. I would still like to see the configuration live somewhere else. The currently layout seems needlessly complicated. Also I think it could live in `libcxx/test` instead of `libcxx/test/libcxx`, leaving `libcxx/test/libcxx` to only contain tests. Also, @jroelofs doesn't want any generated files. Could we use `sys.dont_write_bytecode = True` in `lit.cfg` to turn this off? This way SVN users won't have to worry about generated .pyc files either, and we keep the source directory clean. http://reviews.llvm.org/D6881 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
