LGTM.
We should, however, as a follow-up, think about normalizing how we print these
things in error messages. This example from the regression tests you're adding
seems to be an amusing representative:
vector __bool pixel v___bp; // expected-error {{cannot use '__pixel'
with '__vector bool'}}
So the original source has vector and pixel without underscores, and bool with
them. The error message prints vector and pixel with underscores, and bool
without them. We should probably pick one, or the other, or record whether the
original token had underscores or not and print them in a corresponding way.
The latter is better, but perhaps more work.
http://reviews.llvm.org/D6882
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
