Other than the 80 column violation around line 5994 where the cast<CXXRecordDecl> was changed to a dyn_cast (using clang-format is the easiest way to fix the formatting), the patch LGTM.
On Thu, Jan 8, 2015 at 1:12 PM, Olivier Goffart <[email protected]> wrote: > Hi, > > Please review the attached patch. > It fix a crash while trying to compile the code that is in the testcase > (in C > mode). This crash is a regression since 3.5 > > The problem is that "isCXXClassMember" for the NameDecl of the enum values > returns true even tough we are in C mode. Therefore, the DeclContext is > not a > CXXRecordDecl, but just a plain RecordDecl. > I'm taking the least intrusive approach by handling the case in which the > cast > would otherwise fail. > > Thanks > -- > Olivier
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
