> On Jan 9, 2015, at 11:41 AM, AlexDenisov <[email protected]> wrote: > >> We may not support boxing of any pointer types after all >> (as the underlying API does not manage the collected object). >> So, final patch may need to address that. > > No problem. To be honest, I don’t see real benefits of having such ability, > it was a silly decision to include this functionality (motivated by ‘because > I can’). > >> Please provide more tests >> for NSEdgeInsets and specifically, see that diagnostics come out when >> deployment target does not support it. > > What kind of tests should I add? It has tests for Sema and CodeGen, did I > forget/missed something? > >
Test should show that if some one uses auto boxing for NSEdgeInsets in deployment targets that do not support it, a proper warning is being issued. You may have this test already but I could not locate it. - Fariborz >>>> >>>> - Fariborz
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
