> On Jan 9, 2015, at 5:52 PM, Richard Smith <[email protected]> wrote:
> 
> On Fri, Jan 9, 2015 at 12:32 PM, David Blaikie <[email protected] 
> <mailto:[email protected]>> wrote:
> On Fri, Jan 9, 2015 at 12:25 PM, Marshall Clow <[email protected] 
> <mailto:[email protected]>> wrote:
> Author: marshall
> Date: Fri Jan  9 14:25:52 2015
> New Revision: 225541
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=225541&view=rev 
> <http://llvm.org/viewvc/llvm-project?rev=225541&view=rev>
> Log:
> Walter Brown sent a list of tests which needed 'additional includes' to match 
> what was in the standard. Added these includes to the tests. No changes to 
> the library or test results.
> 
> Richard - would a modularized libc++ (you have the setup for that, yes?) help 
> enforce the right header inclusions in these tests (& other code using 
> libc++)?
> 
> I have such a module map, but I've not run the libc++ tests with it in a long 
> time. IIRC it found a *lot* of missing #includes, many of which were cases 
> where <a> "obviously" includes <b> (but actually isn't required to do so). 
> I'll have another look.

Great!
Thanks.

— Marshall

_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to