Please use llvm_unreachable at the bottom of shouldBeInCOMDAT, gcc warns otherwise. LGTM.
On Thu, Jan 8, 2015 at 6:00 AM, Rafael Espíndola <[email protected] > wrote: > On 8 January 2015 at 03:42, David Majnemer <[email protected]> > wrote: > > I don't think we'd want to keep marking C++ entities as > weak/linkonce/etc. > > in the MSVC ABI if we are splitting the COMDATness out. I guess we still > > sorta need it to talk about the discardability of a symbol... > > And that should really be an independent patch, no? It is basically > the "splitting linkage" discussion and it is larger than this. > > Cheers, > Rafael >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
