Hi Steven,

This mostly looks fine; just one comment:

On 12 January 2015 at 15:00, Steven Wu <[email protected]> wrote:
> +        if (BeginSDK != std::string::npos && EndSDK != std::string::npos) {

These should probably be using StringRef::npos, since under a fairly
bizarre set of circumstances it may differ from std::string::npos.

Tim.
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to